Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: ibc callback is not used #1185

Merged
merged 26 commits into from
Sep 27, 2023
Merged

Problem: ibc callback is not used #1185

merged 26 commits into from
Sep 27, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 26, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe
add cb
d5ae01d 
larger maxCallbackGas
@mmsqe
add interface
6ce558b
mmsqe
mmsqe commented Sep 26, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Sep 26, 2023
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #1185 (947abe0) into main (f11271b) will decrease coverage by 0.34%.
The diff coverage is 8.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
- Coverage   37.62%   37.28%   -0.34%     
==========================================
  Files         114      115       +1     
  Lines       10073    10169      +96     
==========================================
+ Hits         3790     3792       +2     
- Misses       5903     5994      +91     
- Partials      380      383       +3
Files Coverage Δ
x/cronos/events/events.go 27.27% <ø> (ø)
x/cronos/keeper/evm.go 54.54% <100.00%> (-0.35%) ⬇️
x/cronos/migrations/v2/migrate.go 57.14% <25.00%> (-15.59%) ⬇️
x/cronos/types/params.go 68.91% <28.57%> (-3.14%) ⬇️
x/cronos/keeper/precompiles/ica.go 6.66% <22.22%> (+0.52%) ⬆️
x/cronos/simulation/genesis.go 0.00% <0.00%> (ø)
x/cronos/keeper/keeper.go 65.77% <0.00%> (-11.10%) ⬇️
...os/precompile/icacallback/i_ica_callback.abigen.go 0.00% <0.00%> (ø)

calvinaco
calvinaco reviewed Sep 26, 2023
View reviewed changes
x/cronos/keeper/precompiles/ica.go Outdated Show resolved Hide resolved
x/cronos/keeper/keeper.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
x/cronos/keeper/keeper.go Outdated Show resolved Hide resolved
x/cronos/events/bindings/src/ICA.sol Outdated Show resolved Hide resolved
@mmsqe mmsqe marked this pull request as ready for review September 27, 2023 06:07
@mmsqe mmsqe requested a review from a team as a code owner September 27, 2023 06:07
@mmsqe mmsqe requested review from yihuang and thomas-nguy and removed request for a team September 27, 2023 06:07
yihuang
yihuang reviewed Sep 27, 2023
View reviewed changes
x/cronos/keeper/keeper.go Outdated Show resolved Hide resolved
yihuang
yihuang approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a changelog

@mmsqe mmsqe enabled auto-merge September 27, 2023 11:06
@mmsqe mmsqe added this pull request to the merge queue Sep 27, 2023
Merged via the queue into crypto-org-chain:main with commit aee4960 Sep 27, 2023
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinaco calvinaco calvinaco left review comments

@yihuang yihuang yihuang approved these changes

@thomas-nguy thomas-nguy Awaiting requested review from thomas-nguy thomas-nguy is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmsqe @yihuang @calvinaco